Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update crates to latest master #229

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update crates to latest master #229

wants to merge 1 commit into from

Conversation

pgherveou
Copy link
Contributor

No description provided.

@ascjones
Copy link
Contributor

ascjones commented Apr 8, 2024

WIll this also be a tagged github release?

@smiasojed
Copy link
Contributor

smiasojed commented Apr 8, 2024

WIll this also be a tagged github release?

Correct me if I'm wrong, but all the changes we need for ink5 are in the 1.9.0 release. So, we could release the crates from it. In this PR, we are aligned with the master, but as I understand it is not required to be released now.

@ascjones
Copy link
Contributor

ascjones commented Apr 8, 2024

I am assuming this is to do with use-ink/ink#1912. If so then I have answered my own question because it will require a github tagged release.

@smiasojed
Copy link
Contributor

smiasojed commented Apr 8, 2024

@cmichi @ascjones, please advise if we need two releases: one aligned with polkadot-release 1.9.0 (fully compatible with ink 5.0.0 and we publish crates), and a second one with this commit, or if we will do just one based on this commit and without publishing crates?

@ascjones
Copy link
Contributor

ascjones commented Apr 8, 2024

How about the following:

  1. Don't merge this PR yet
  2. Create a new PR with the latest crates.
  3. Do a 0.40 release from master.
  4. Then rebase & merge this PR
  5. New (github tag only) release of 0.41.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants