Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nix support for dev #438

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

m0ssc0de
Copy link
Contributor

No description provided.

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Feb 12, 2022

User @m0ssc0de, please sign the CLA here.

@gilescope
Copy link

https://gutier.io/post/development-using-rust-with-nix/ - I think people are switching over to oxalica (The company steve K works for) rather than mozilla as the base these days.

@bernardoaraujor
Copy link

I ran a successful build with the proposed shell.nix on my NixOS setup, which probably means the PR is ok.

I'm a bit confused about the dependencies though.
Given the prerequisites, why is it enough that shell.nix has no mentions to PostgresSQL?

@ggwpez
Copy link
Member

ggwpez commented Feb 15, 2022

I'm a bit confused about the dependencies though. Given the prerequisites, why is it enough that shell.nix has no mentions to PostgresSQL?

Maybe for running the tests?
I think if we want to to fully support this we should add a CI build+test step.

@bernardoaraujor
Copy link

I'm a bit confused about the dependencies though. Given the prerequisites, why is it enough that shell.nix has no mentions to PostgresSQL?

Maybe for running the tests?
I think if we want to to fully support this we should add a CI build+test step.

CI build+test is indeed important for long term sustainability.

I submitted a similar shell.nix PR to substrate-contracts-node recently but the ink! team rejected it based on the maintenance burden it would add to them.

Perhaps the code owner of this project should be on the loop.

@dvdplm
Copy link
Contributor

dvdplm commented Feb 16, 2022

Perhaps the code owner of this project should be on the loop.

We're here reading. Not nix users ourselves (yet) so you are indeed correct that this would have to be community maintained and it is a concern. I'm not opposed to adding it if we see active users step up.

@insipx
Copy link
Collaborator

insipx commented Feb 16, 2022

This looks good (if it's decided nix is ok to use for archive), I can post my old nix config too if that's of interest. I think Oxalica is definitely better for managing rust dependencies IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants