-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
State Tracing #134
State Tracing #134
Conversation
update sqlx from beta to 0.4.0 release
Didn't expect a review so fast! There are some problems with the current implementation I wrote up and was going to ask for feedback today State tracing seems to work -- sort of. Replacing WASM code at runtime and tracing itself is working, but Substrate Archive is getting traces for only some parts of the substrate landscape: Haven't made the migrations yet because i'm not sure if there might be something wrong with how i've setup the tracing. So far, it just logs the |
let executor = | ||
LocalCallExecutor::new(backend.clone(), executor, Box::new(TaskExecutor::new()), Default::default())?; | ||
let executor = NativeExecutor::<Dispatch>::new( | ||
WasmExecutionMethod::Interpreted, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not WasmExecutionMethod::Compiled
? It's enabled in this PR and I suppose it's faster?!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I measured this and it's actually not faster. I was surprised by this and it might be worth taking a deeper look. When syncing the chain in normal polkadot
using --wasm-execution=Compiled
is much much faster.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I see.
Co-authored-by: Niklas Adolfsson <[email protected]>
…e-archive into insipx/state-tracing
- Remove clones in Trace database insert - remove frame-benchmarking dependency from polkadot-archive - add new WASM binaries for 8.27 (older ones didn't work) - add comment explaining why we unwrap Arc and Mutex
Continuation of work from #92
Not ready for merge yet because:
In this PR
ActorContext
->SystemConfig
native_executor_instance
in order to have access and change around the HostFunctions available in the executing WASM environment