This repository was archived by the owner on Nov 15, 2023. It is now read-only.
Use RuntimeHoldReason for the NIS pallet HoldReason #7017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KiChjang
added
A0-please_review
ggwpez
approved these changes
Apr 6, 2023
kianenigma
approved these changes
Apr 6, 2023
sam0x17
approved these changes
Apr 6, 2023
bkchr
reviewed
Apr 9, 2023
| /// The NIS Pallet has reserved it for a non-fungible receipt. | ||
| #[codec(index = 0)] | ||
| NftReceipt = 0, | ||
| pub const NisHoldReason: RuntimeHoldReason = RuntimeHoldReason::Nis(pallet_nis::HoldReason::NftReceipt); |
There was a problem hiding this comment.
We only need this for tests or?
So can we move it to the test?
There was a problem hiding this comment.
It's to make sure that the encoding didn't change before and after the code changes in this PR. In the future, it would probably be good to keep this around so that we don't accidentally change the encoding via modifying the composite_enum attribute.
There was a problem hiding this comment.
Ah sorry, I misread. We do need this to configure the HoldReason on the NIS pallet.
gpestana
approved these changes
Apr 10, 2023
bkchr
approved these changes
Apr 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partial paritytech/polkadot-sdk#236.
Removes the user-defined enums on the runtime source file and instead uses the macro-generated
RuntimeHoldReasonfor the NIS pallet'sHoldReason.