[pallet-revive] adjust fee dry-run calculation #6393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pgherveou
commented
Nov 6, 2024
•
pgherveou
commented
- Fix bare_eth_transact so that it estimate more precisely the transaction fee
- Add some context to the build.rs to make it easier to troubleshoot errors
- Add TransactionBuilder for the RPC tests.
- Improve error message, proxy rpc error from the node and handle reverted error message
- Add logs in ReceiptInfo
|
/cmd prdoc --audience runtime_dev --bump minor |
pgherveou
added
R0-silent
athei
reviewed
Nov 8, 2024
pgherveou
commented
Nov 8, 2024
| @@ -99,42 +99,67 @@ struct BlockCache<const N: usize> { | |||
| tx_hashes_by_block_and_index: HashMap<H256, HashMap<U256, H256>>, | |||
| } | |||
|
|
|||
| fn unwrap_subxt_err(err: &subxt::Error) -> String { | |||
| /// Unwrap the original `jsonrpsee::core::client::Error::Call` error. | |||
| fn unwrap_call_err(err: &subxt::error::RpcError) -> Option<ErrorObjectOwned> { | |||
There was a problem hiding this comment.
@jsdw here is the downcast magic, fyi
athei
approved these changes
Nov 11, 2024
xermicus
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.