Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2409] Backport #5327 #5798

Merged
merged 3 commits into from
Sep 24, 2024
Merged

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]

Backport #5327 into stable2409 from bkontur.

See the documentation on how to use this bot.

@paritytech-cmd-bot-polkadot-sdk
Copy link
Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-5327-to-stable2409
git worktree add --checkout .worktree/backport-5327-to-stable2409 backport-5327-to-stable2409
cd .worktree/backport-5327-to-stable2409
git reset --hard HEAD^
git cherry-pick -x 8735c66393978fec6fd811ef7832b08355a2885a
git push --force-with-lease

@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Sep 22, 2024
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7403811

It is a first step for switching to the `frame-omni-bencher` for CI.

This PR includes several changes related to generating chain specs plus:

- [x] pallet `assigned_slots` fix missing `#[serde(skip)]` for phantom
- [x] pallet `paras_inherent` benchmark fix - cherry-picked from
#5688
- [x] migrates `get_preset` to the relevant runtimes
- [x] fixes Rococo genesis presets - does not work
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7317249
- [x] fixes Rococo benchmarks for CI
- [x] migrate westend genesis
- [x] remove wococo stuff

Closes: #5680

- Fix for frame-omni-bencher
#5655
- Enable new short-benchmarking CI -
#5706
- Remove gitlab pipelines for short benchmarking
- refactor all Cumulus runtimes to use `get_preset` -
#5704
- #5705
- #5700
- [ ] Backport to the stable

---------

Co-authored-by: command-bot <>
Co-authored-by: ordian <[email protected]>
(cherry picked from commit 8735c66)
@bkontur bkontur marked this pull request as ready for review September 22, 2024 18:08
@bkontur bkontur requested review from a team as code owners September 22, 2024 18:08
@paritytech-review-bot paritytech-review-bot bot requested a review from a team September 24, 2024 13:27
@EgorPopelyaev EgorPopelyaev merged commit 9543037 into stable2409 Sep 24, 2024
64 of 72 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-5327-to-stable2409 branch September 24, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants