Zombienet upgrade test #5794
Open
Zombienet upgrade test #5794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepoviola
added
R0-silent
alexggh
reviewed
Sep 25, 2024
| spec_name: create_runtime_str!("rococo"), | ||
| impl_name: create_runtime_str!("parity-rococo-v2.0"), | ||
| authoring_version: 0, | ||
| spec_version: 1_016_000, |
There was a problem hiding this comment.
I would extract out:
CONST SPEC_VERSION: 1_015_000 and then here I would use SPEC_VERSION + 1.
There was a problem hiding this comment.
can extract out, I will leave this way.
error: only numeric literals (e.g. `10`) are supported here
--> polkadot-sdk/polkadot/runtime/rococo/src/lib.rs:187:16
|
187 | spec_version: SPEC_VERSION,
Thx!
| .with_node(|node| { | ||
| node.with_name("latest-release") | ||
| // used for getting the chain-spec | ||
| .with_image("parity/polkadot:latest") |
There was a problem hiding this comment.
Can we somehow use the exact runtime-image that roco chain is currently using, or at least the last stable release version, since the upgrades happened all at once.
There was a problem hiding this comment.
parity/polkadot:latest this tag should point to the latest release (stable).
Thx!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add zombienet test for upgrading runtime
prWe use a version built in the pipeline (of rococo-runtime) with the
spec_versionincremented to perform the upgrade and verify then the block production and the expected version.Thx!
NOTE: This tests is behind the
zombienetfeature and you can run with