Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update CODE_OF_CONDUCT.md #5783

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update CODE_OF_CONDUCT.md #5783

wants to merge 1 commit into from

Conversation

ltfschoen
Copy link

@ltfschoen ltfschoen commented Sep 19, 2024 •
edited
Loading

convert into clickable link

@ltfschoen
Update CODE_OF_CONDUCT.md
4b22da6 
convert into clickable link
@bkchr bkchr added the R0-silent Changes should not be mentioned in any release notes label Sep 20, 2024
@bkchr bkchr requested a review from ggwpez September 20, 2024 07:08
ggwpez
ggwpez reviewed Sep 20, 2024
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its a symlink... does your OS not resolve that?

@ltfschoen
Copy link
Author

Its a symlink... does your OS not resolve that?

if is not a symlink when I'm navigating through the codebase on Github, it just appears as plain text that i can't click

@shawntabrizi
Copy link
Member

yes, i had the same problem when trying to look at contribution guidelines via github. I dont think a symlink here is a good choice for this file.

@shawntabrizi shawntabrizi mentioned this pull request Sep 21, 2024
Open
ggwpez
ggwpez approved these changes Sep 21, 2024
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well okay, we could also move the file up then, but all the other docs are in the docs folder.

@bkchr
Copy link
Member

bkchr commented Sep 22, 2024

#5447 this was fixed here to make it work natively with github. So, when you click there on code of conduct it works. Actually we should try if this works as well. Maybe we should move these files to .github and then users are not "confused".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ltfschoen @shawntabrizi @bkchr @ggwpez