[3 / 5] Move crypto checks in the approval-distribution #4847
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexggh
changed the title
|
The CI pipeline was cancelled due to failure one of the required jobs. |
6 tasks
alexggh
changed the title
alexggh
force-pushed
the
alexaggh/approval-voting-parallel-3-5
branch
from
03945da
to
78708d7
Compare
alexggh
merged commit 78708d7
into
alexaggh/approval-voting-parallel-2-5
9 of 13 checks passed
alexggh
force-pushed
the
alexaggh/approval-voting-parallel-2-5
branch
from
31767a9
to
7add070
Compare
User @dashangcun, please sign the CLA here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisite
Start with reading #4849 (comment) first
Description
This PR contain changes, so that the crypto checks are performed by the approval-distribution subsystem instead of the approval-voting one. The benefit for these, is twofold: