Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restoring disable-runtime-api for test chains #4325

Closed
wants to merge 12 commits into from
Closed

Restoring disable-runtime-api for test chains #4325

wants to merge 12 commits into from

Conversation

bolajahmad
Copy link
Contributor

Adds disable-runtime-api back to rococo and westend. Previously removed.

Partly closes, #1621 . Kusams and Polkadot will be updated on the runtimes codebase in a seperate PR.

@cla-bot-2021
Copy link

cla-bot-2021 bot commented Apr 29, 2024

User @bolajahmad, please sign the CLA here.

bkchr
bkchr reviewed Apr 30, 2024
View reviewed changes
polkadot/runtime/westend/src/lib.rs Outdated Show resolved Hide resolved
polkadot/runtime/rococo/src/lib.rs Outdated Show resolved Hide resolved
polkadot/runtime/rococo/Cargo.toml Show resolved Hide resolved
bkchr
bkchr reviewed May 17, 2024
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please revert the unrelated changes on your pr? Otherwise it looks good.

polkadot/runtime/rococo/Cargo.toml Outdated Show resolved Hide resolved
polkadot/runtime/westend/Cargo.toml Outdated Show resolved Hide resolved
@bkchr
Copy link
Member

bkchr commented May 19, 2024

@bolajahmad could you please revert the changes that are not related to your pr?

@bolajahmad
Copy link
Contributor Author

@bolajahmad could you please revert the changes that are not related to your pr?

Hi @bkchr, i tried to cleanup the branch and revert unrelated changes to my PR. I've removed the changes that seemed weird and it should be good. I'm sorry to bother you when you're reviewing my changes but I can't find anymore unrelated changes in this PR. I'll appreciate if you mention something specific you think I need to remove/revert too🙏🏼

@bkchr
Copy link
Member

bkchr commented May 22, 2024

https://github.com/paritytech/polkadot-sdk/pull/4325/files#diff-5264d812f7aadfc486efffd3322b11c8dee5e8ddf2e77e0a9e70b573f3d2afddR91 here for example where you import AccountIdLookup which was not there before.

Or the formatting changes here

@bkchr bkchr added the R0-silent Changes should not be mentioned in any release notes label Jul 24, 2024
@bolajahmad bolajahmad requested a review from bkchr July 30, 2024 10:54
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7063196

@bkchr
Copy link
Member

bkchr commented Sep 19, 2024

The issue was closed as not needed anymore, so we can do the same with this pr.

@bkchr bkchr closed this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr Awaiting requested review from bkchr

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bolajahmad @bkchr @paritytech-cicd-pr