Skip to content

Commit

Permalink
add prdoc and some fixes
Browse files Browse the repository at this point in the history
  • Loading branch information
vedhavyas committed Jun 24, 2024
1 parent 246d3f3 commit d06738b
Show file tree
Hide file tree
Showing 4 changed files with 24 additions and 3 deletions.
2 changes: 1 addition & 1 deletion cumulus/client/network/src/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,7 @@ impl RelayChainInterface for DummyRelayChainInterface {
impl_version: 0,
apis: Cow::Owned(apis),
transaction_version: 5,
state_version: 1,
system_version: 1,
})
}
}
Expand Down
2 changes: 1 addition & 1 deletion cumulus/client/pov-recovery/src/tests.rs
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,7 @@ impl RelayChainInterface for Relaychain {
impl_version: 0,
apis: Cow::Owned(apis),
transaction_version: 5,
state_version: 1,
system_version: 1,
})
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ pub const VERSION: RuntimeVersion = RuntimeVersion {
impl_version: 1,
apis: RUNTIME_API_VERSIONS,
transaction_version: 1,
state_version: 1,
system_version: 1,
};

/// The signed extensions that are added to the runtime.
Expand Down
21 changes: 21 additions & 0 deletions prdoc/pr_4257.prdoc
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
# Schema: Polkadot SDK PRDoc Schema (prdoc) v1.0.0
# See doc at https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/prdoc/schema_user.json

title: Rename `state_version` in `RuntimeVersion` to `system_version`.

doc:
- audience: Runtime Dev
description: |
This PR renames `state_version` in `RuntimeVersion` to `system_version`. `system_version=2` signifies
that extrinsic root derivation uses `StateVersion::V1`.

- audience: Runtime User
description: |
`RuntimeVersion`'s `state_version` is renames to `system_version`. Applications using that type and its field
must update their code to reflect the changes

crates:
- name: frame-system
bump: minor
- name: sp-version
bump: minor

0 comments on commit d06738b

Please sign in to comment.