moved location conversion test to test root

paritytech · Sep 30, 2024 · b60b6fd · b60b6fd
1 parent 65538fe
commit b60b6fd
Showing 1 changed file with 124 additions and 127 deletions.
diff --git a/cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/tests/tests.rs b/cumulus/parachains/runtimes/bridge-hubs/bridge-hub-rococo/tests/tests.rs
@@ -120,26 +120,6 @@ bridge_hub_test_utils::test_cases::include_teleports_for_native_asset_works!(
 	bp_bridge_hub_rococo::BRIDGE_HUB_ROCOCO_PARACHAIN_ID
 );
 
-#[test]
-fn change_required_stake_by_governance_works() {
-	bridge_hub_test_utils::test_cases::change_storage_constant_by_governance_works::<
-		Runtime,
-		bridge_common_config::RequiredStakeForStakeAndSlash,
-		Balance,
-	>(
-		collator_session_keys(),
-		bp_bridge_hub_rococo::BRIDGE_HUB_ROCOCO_PARACHAIN_ID,
-		Box::new(|call| RuntimeCall::System(call).encode()),
-		|| {
-			(
-				bridge_common_config::RequiredStakeForStakeAndSlash::key().to_vec(),
-				bridge_common_config::RequiredStakeForStakeAndSlash::get(),
-			)
-		},
-		|old_value| old_value.checked_mul(2).unwrap(),
-	)
-}
-
 mod bridge_hub_westend_tests {
 	use super::*;
 	use bp_messages::LegacyLaneId;
@@ -716,117 +696,134 @@ mod bridge_hub_bulletin_tests {
 			false,
 		)
 	}
+}
 
-	#[test]
-	fn location_conversion_works() {
-		// the purpose of hardcoded values is to catch an unintended location conversion logic
-		// change.
-		struct TestCase {
-			description: &'static str,
-			location: Location,
-			expected_account_id_str: &'static str,
-		}
+#[test]
+fn change_required_stake_by_governance_works() {
+	bridge_hub_test_utils::test_cases::change_storage_constant_by_governance_works::<
+		Runtime,
+		bridge_common_config::RequiredStakeForStakeAndSlash,
+		Balance,
+	>(
+		collator_session_keys(),
+		bp_bridge_hub_rococo::BRIDGE_HUB_ROCOCO_PARACHAIN_ID,
+		Box::new(|call| RuntimeCall::System(call).encode()),
+		|| {
+			(
+				bridge_common_config::RequiredStakeForStakeAndSlash::key().to_vec(),
+				bridge_common_config::RequiredStakeForStakeAndSlash::get(),
+			)
+		},
+		|old_value| old_value.checked_mul(2).unwrap(),
+	)
+}
 
-		let test_cases = vec![
-			// DescribeTerminus
-			TestCase {
-				description: "DescribeTerminus Parent",
-				location: Location::new(1, Here),
-				expected_account_id_str: "5Dt6dpkWPwLaH4BBCKJwjiWrFVAGyYk3tLUabvyn4v7KtESG",
-			},
-			TestCase {
-				description: "DescribeTerminus Sibling",
-				location: Location::new(1, [Parachain(1111)]),
-				expected_account_id_str: "5Eg2fnssmmJnF3z1iZ1NouAuzciDaaDQH7qURAy3w15jULDk",
-			},
-			// DescribePalletTerminal
-			TestCase {
-				description: "DescribePalletTerminal Parent",
-				location: Location::new(1, [PalletInstance(50)]),
-				expected_account_id_str: "5CnwemvaAXkWFVwibiCvf2EjqwiqBi29S5cLLydZLEaEw6jZ",
-			},
-			TestCase {
-				description: "DescribePalletTerminal Sibling",
-				location: Location::new(1, [Parachain(1111), PalletInstance(50)]),
-				expected_account_id_str: "5GFBgPjpEQPdaxEnFirUoa51u5erVx84twYxJVuBRAT2UP2g",
-			},
-			// DescribeAccountId32Terminal
-			TestCase {
-				description: "DescribeAccountId32Terminal Parent",
-				location: Location::new(
-					1,
-					[Junction::AccountId32 { network: None, id: AccountId::from(Alice).into() }],
-				),
-				expected_account_id_str: "5EueAXd4h8u75nSbFdDJbC29cmi4Uo1YJssqEL9idvindxFL",
-			},
-			TestCase {
-				description: "DescribeAccountId32Terminal Sibling",
-				location: Location::new(
-					1,
-					[
-						Parachain(1111),
-						Junction::AccountId32 { network: None, id: AccountId::from(Alice).into() },
-					],
-				),
-				expected_account_id_str: "5Dmbuiq48fU4iW58FKYqoGbbfxFHjbAeGLMtjFg6NNCw3ssr",
-			},
-			// DescribeAccountKey20Terminal
-			TestCase {
-				description: "DescribeAccountKey20Terminal Parent",
-				location: Location::new(1, [AccountKey20 { network: None, key: [0u8; 20] }]),
-				expected_account_id_str: "5F5Ec11567pa919wJkX6VHtv2ZXS5W698YCW35EdEbrg14cg",
-			},
-			TestCase {
-				description: "DescribeAccountKey20Terminal Sibling",
-				location: Location::new(
-					1,
-					[Parachain(1111), AccountKey20 { network: None, key: [0u8; 20] }],
-				),
-				expected_account_id_str: "5CB2FbUds2qvcJNhDiTbRZwiS3trAy6ydFGMSVutmYijpPAg",
-			},
-			// DescribeTreasuryVoiceTerminal
-			TestCase {
-				description: "DescribeTreasuryVoiceTerminal Parent",
-				location: Location::new(
-					1,
-					[Plurality { id: BodyId::Treasury, part: BodyPart::Voice }],
-				),
-				expected_account_id_str: "5CUjnE2vgcUCuhxPwFoQ5r7p1DkhujgvMNDHaF2bLqRp4D5F",
-			},
-			TestCase {
-				description: "DescribeTreasuryVoiceTerminal Sibling",
-				location: Location::new(
-					1,
-					[Parachain(1111), Plurality { id: BodyId::Treasury, part: BodyPart::Voice }],
-				),
-				expected_account_id_str: "5G6TDwaVgbWmhqRUKjBhRRnH4ry9L9cjRymUEmiRsLbSE4gB",
-			},
-			// DescribeBodyTerminal
-			TestCase {
-				description: "DescribeBodyTerminal Parent",
-				location: Location::new(1, [Plurality { id: BodyId::Unit, part: BodyPart::Voice }]),
-				expected_account_id_str: "5EBRMTBkDisEXsaN283SRbzx9Xf2PXwUxxFCJohSGo4jYe6B",
-			},
-			TestCase {
-				description: "DescribeBodyTerminal Sibling",
-				location: Location::new(
-					1,
-					[Parachain(1111), Plurality { id: BodyId::Unit, part: BodyPart::Voice }],
-				),
-				expected_account_id_str: "5DBoExvojy8tYnHgLL97phNH975CyT45PWTZEeGoBZfAyRMH",
-			},
-		];
+#[test]
+fn location_conversion_works() {
+	// the purpose of hardcoded values is to catch an unintended location conversion logic
+	// change.
+	struct TestCase {
+		description: &'static str,
+		location: Location,
+		expected_account_id_str: &'static str,
+	}
+
+	let test_cases = vec![
+		// DescribeTerminus
+		TestCase {
+			description: "DescribeTerminus Parent",
+			location: Location::new(1, Here),
+			expected_account_id_str: "5Dt6dpkWPwLaH4BBCKJwjiWrFVAGyYk3tLUabvyn4v7KtESG",
+		},
+		TestCase {
+			description: "DescribeTerminus Sibling",
+			location: Location::new(1, [Parachain(1111)]),
+			expected_account_id_str: "5Eg2fnssmmJnF3z1iZ1NouAuzciDaaDQH7qURAy3w15jULDk",
+		},
+		// DescribePalletTerminal
+		TestCase {
+			description: "DescribePalletTerminal Parent",
+			location: Location::new(1, [PalletInstance(50)]),
+			expected_account_id_str: "5CnwemvaAXkWFVwibiCvf2EjqwiqBi29S5cLLydZLEaEw6jZ",
+		},
+		TestCase {
+			description: "DescribePalletTerminal Sibling",
+			location: Location::new(1, [Parachain(1111), PalletInstance(50)]),
+			expected_account_id_str: "5GFBgPjpEQPdaxEnFirUoa51u5erVx84twYxJVuBRAT2UP2g",
+		},
+		// DescribeAccountId32Terminal
+		TestCase {
+			description: "DescribeAccountId32Terminal Parent",
+			location: Location::new(
+				1,
+				[Junction::AccountId32 { network: None, id: AccountId::from(Alice).into() }],
+			),
+			expected_account_id_str: "5EueAXd4h8u75nSbFdDJbC29cmi4Uo1YJssqEL9idvindxFL",
+		},
+		TestCase {
+			description: "DescribeAccountId32Terminal Sibling",
+			location: Location::new(
+				1,
+				[
+					Parachain(1111),
+					Junction::AccountId32 { network: None, id: AccountId::from(Alice).into() },
+				],
+			),
+			expected_account_id_str: "5Dmbuiq48fU4iW58FKYqoGbbfxFHjbAeGLMtjFg6NNCw3ssr",
+		},
+		// DescribeAccountKey20Terminal
+		TestCase {
+			description: "DescribeAccountKey20Terminal Parent",
+			location: Location::new(1, [AccountKey20 { network: None, key: [0u8; 20] }]),
+			expected_account_id_str: "5F5Ec11567pa919wJkX6VHtv2ZXS5W698YCW35EdEbrg14cg",
+		},
+		TestCase {
+			description: "DescribeAccountKey20Terminal Sibling",
+			location: Location::new(
+				1,
+				[Parachain(1111), AccountKey20 { network: None, key: [0u8; 20] }],
+			),
+			expected_account_id_str: "5CB2FbUds2qvcJNhDiTbRZwiS3trAy6ydFGMSVutmYijpPAg",
+		},
+		// DescribeTreasuryVoiceTerminal
+		TestCase {
+			description: "DescribeTreasuryVoiceTerminal Parent",
+			location: Location::new(1, [Plurality { id: BodyId::Treasury, part: BodyPart::Voice }]),
+			expected_account_id_str: "5CUjnE2vgcUCuhxPwFoQ5r7p1DkhujgvMNDHaF2bLqRp4D5F",
+		},
+		TestCase {
+			description: "DescribeTreasuryVoiceTerminal Sibling",
+			location: Location::new(
+				1,
+				[Parachain(1111), Plurality { id: BodyId::Treasury, part: BodyPart::Voice }],
+			),
+			expected_account_id_str: "5G6TDwaVgbWmhqRUKjBhRRnH4ry9L9cjRymUEmiRsLbSE4gB",
+		},
+		// DescribeBodyTerminal
+		TestCase {
+			description: "DescribeBodyTerminal Parent",
+			location: Location::new(1, [Plurality { id: BodyId::Unit, part: BodyPart::Voice }]),
+			expected_account_id_str: "5EBRMTBkDisEXsaN283SRbzx9Xf2PXwUxxFCJohSGo4jYe6B",
+		},
+		TestCase {
+			description: "DescribeBodyTerminal Sibling",
+			location: Location::new(
+				1,
+				[Parachain(1111), Plurality { id: BodyId::Unit, part: BodyPart::Voice }],
+			),
+			expected_account_id_str: "5DBoExvojy8tYnHgLL97phNH975CyT45PWTZEeGoBZfAyRMH",
+		},
+	];
 
-		for tc in test_cases {
-			let expected = AccountId::from_string(tc.expected_account_id_str)
-				.expect("Invalid AccountId string");
+	for tc in test_cases {
+		let expected =
+			AccountId::from_string(tc.expected_account_id_str).expect("Invalid AccountId string");
 
-			let got = LocationToAccountHelper::<AccountId, LocationToAccountId>::convert_location(
-				tc.location.into(),
-			)
-			.unwrap();
+		let got = LocationToAccountHelper::<AccountId, LocationToAccountId>::convert_location(
+			tc.location.into(),
+		)
+		.unwrap();
 
-			assert_eq!(got, expected, "{}", tc.description);
-		}
+		assert_eq!(got, expected, "{}", tc.description);
 	}
 }