Skip to content

Commit

Permalink
Do not include polkadot-launch in shell.nix (#152)
Browse files Browse the repository at this point in the history
The reason for this is that, shell.nix is used for setting up the
development environment, when you work are developing the project.

For that, IMO, it's way more convenient to use `yarn`. The reason for
that is that when you change something you can immediatelly run `yarn
start` and see the results.

However, in order to start the shell via lorri or whatever any changes
to this project will trigger nix rebuild which can take quite some time.

So I think it would be better in the end to remove polkadot-launch from
here. If needed, it can be installed from ./default.nix
  • Loading branch information
pepyakin authored Nov 20, 2021
1 parent dcfb229 commit 0a526b3
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions shell.nix
Original file line number Diff line number Diff line change
@@ -1,10 +1,6 @@
{ pkgs ? import <nixpkgs> { } }:
let
polkadot-launch = pkgs.callPackage ./default.nix { };
in
with pkgs; mkShell {

This comment has been minimized.

Copy link
@Brycewetzel

Brycewetzel Dec 21, 2023

well put, agreed.

buildInputs = [
polkadot-launch
(yarn.override { nodejs = nodejs-14_x; })
];
}

0 comments on commit 0a526b3

Please sign in to comment.