Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[polkadot-staging] Separate send_message() validations #2795

Merged

Conversation

serban300
Copy link
Collaborator

Addresses #2776 for the polkadot-staging branch

@serban300 serban300 self-assigned this Jan 17, 2024
@serban300 serban300 changed the title Separate send_message() validations [polkadot-staging] Separate send_message() validations Jan 17, 2024
Copy link
Contributor

@svyatonik svyatonik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

modules/messages/src/lib.rs Outdated Show resolved Hide resolved
primitives/messages/src/source_chain.rs Show resolved Hide resolved
primitives/messages/src/source_chain.rs Outdated Show resolved Hide resolved
modules/messages/src/mock.rs Outdated Show resolved Hide resolved
Copy link
Contributor

@bkontur bkontur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgmt, I like that send_message does not return a Result. I guess, it is compliant with the philosophy of ExportXcm::validate/deliver.

@serban300 serban300 merged commit dfec8bc into paritytech:polkadot-staging Jan 18, 2024
13 checks passed
serban300 added a commit to serban300/parity-bridges-common that referenced this pull request Mar 27, 2024
…h#2795)

* Fix xcm-bridge-hub build

* Move send_message definition to MessagesBridge impl

* Make send_message infallible

* Split `MessagesBridge` into 2 phases

Split `MessagesBridge` into 2 phases:
- message validation
- message sending
serban300 added a commit to serban300/parity-bridges-common that referenced this pull request Apr 8, 2024
…h#2795)

* Fix xcm-bridge-hub build

* Move send_message definition to MessagesBridge impl

* Make send_message infallible

* Split `MessagesBridge` into 2 phases

Split `MessagesBridge` into 2 phases:
- message validation
- message sending
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants