Bump version #446
Merged
Bump version #446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
approved these changes
Jul 4, 2019
core-client/Cargo.toml
Outdated
| @@ -8,7 +8,7 @@ keywords = ["jsonrpc", "json-rpc", "json", "rpc", "serde"] | |||
| license = "MIT" | |||
| name = "jsonrpc-core-client" | |||
| repository = "https://github.com/paritytech/jsonrpc" | |||
| version = "12.0.0" | |||
| version = "13.0.0" | |||
There was a problem hiding this comment.
Do we really need 13.0? Can't we just bump to 12.1? Are there any breaking changes?
There was a problem hiding this comment.
If there is a bug in handling existing #[pubsub] macros it will break builds.
There was a problem hiding this comment.
I'd rather keep all creates version aligned. So if we feel there is a reason to bump to 13.0 let's do that, but if there are no breaking changes that we know of, let's stick to 12.1 imho.
There was a problem hiding this comment.
Actually there is also an addition to core https://github.com/paritytech/jsonrpc/pull/436/files#diff-77e9ef3aa593be6048a014ed42ef10dbR34
So upgrade all crates to 12.1?
Didn't see your message above. Will do 12.1
This reverts commit fde4053
|
So is this happening? :) |
|
Waiting on something from @tomusdrw
…On Mon, 8 Jul 2019, 13:01 David Craven, ***@***.***> wrote:
So is this happening? :)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#446?email_source=notifications&email_token=AAASOQQAUZVJKUJFP7FCL2LP6MT73A5CNFSM4H54QDGKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODZM3T7Q#issuecomment-509196798>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAASOQX77DH3DBCGAE5WXNTP6MT73ANCNFSM4H54QDGA>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for a release to include the pubsub client #436.