[node] add support for extraDerivation for existingSecrets. #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is common practice for secrets to be created separately by a secret manager, and the Helm chart should accommodate this usage. Previously, it was only possible to configure the key for a single Substrate node, which limited the stateful set to a replica count of one.
This PR introduces the ability to use
node.existingSecrets.extraDerivation, enabling the same seed key to be utilized across multiple nodes. Furthermore, it adds support fornode.existingSecrets.nodeKey.appendPodIndexfor node key secrets, allowing multiple node keys to be stored within the same Kubernetes secret.Changes
extraDerivation.node.existingSecretsusage.