Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Node] Address issue with underscore in chain name #310

Merged
merged 4 commits into from
Nov 10, 2023

Conversation

lazam
Copy link
Contributor

@lazam lazam commented Nov 10, 2023

K8s doesn't allow an underscore in pod name due to RFC 1123

a lowercase RFC 1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name', or '123-abc', regex used for validation is '[a-z0-9]([-a-z0-9]*[a-z0-9])?')

This prevents to easily use the node.chain variable for chain's with underscore in its name such as collectives_polkadot. The solution is to just replace it with - to conform with the standard in the pod name.

@lazam lazam merged commit d20a6f6 into main Nov 10, 2023
3 checks passed
@lazam lazam deleted the al-node-support-underscore branch November 10, 2023 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants