Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose the api-sidecar prometheus port on the service #297

Merged
merged 1 commit into from
Sep 4, 2023
Merged

Expose the api-sidecar prometheus port on the service #297

merged 1 commit into from
Sep 4, 2023

Conversation

PierreBesson
Copy link
Contributor

This fixes prometheus scraping set on the service-monitor.

@PierreBesson PierreBesson force-pushed the pib-expose-substrate-api-sidecar-metrics-port branch from 5f459ae to 93f62b6 Compare September 4, 2023 10:19
BulatSaif
BulatSaif approved these changes Sep 4, 2023
View reviewed changes
Copy link
Contributor

@BulatSaif BulatSaif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, fix CI before merging.

@PierreBesson PierreBesson force-pushed the pib-expose-substrate-api-sidecar-metrics-port branch from 93f62b6 to 299fe6e Compare September 4, 2023 12:18
@PierreBesson PierreBesson merged commit 511f080 into main Sep 4, 2023
2 checks passed
@PierreBesson PierreBesson deleted the pib-expose-substrate-api-sidecar-metrics-port branch September 4, 2023 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BulatSaif BulatSaif BulatSaif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@PierreBesson @BulatSaif