Add cleanup step on failed chain snapshot restoration #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: bakhtin <[email protected]>
BulatSaif
approved these changes
Jul 5, 2023
BulatSaif
reviewed
Jul 5, 2023
BulatSaif
requested changes
Jul 5, 2023
Signed-off-by: bakhtin <[email protected]>
Signed-off-by: bakhtin <[email protected]>
BulatSaif
approved these changes
Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chain snapshot restoration script may fail leaving empty chain data directory on the disk.
On the first run of the script the chain data directory is created. If the script fails the directory remains empty while K8s will re-run failed init container. On the second execution the script will detect that chain data directory is present and will skip snapshot restoration even though it was not successful in the first try. The empty directory will then be mounted to the main node container and the chain will start syncing from scratch (possibly taking many days).
Add a
trapcommand to do a cleanup (removing the chain directory) if any error occurs during the snapshot restoration process and avoid above situation from happening.