Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pipefail option not supported in node container image #266

Merged
merged 1 commit into from
Jul 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/node/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
name: node
description: A Helm chart to deploy Substrate/Polkadot nodes
type: application
version: 5.0.0
version: 5.0.1
maintainers:
- name: Parity
url: https://github.com/paritytech/helm-charts
Expand Down
2 changes: 1 addition & 1 deletion charts/node/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ This is intended behaviour. Make sure to run `git add -A` once again to stage ch

# Substrate/Polkadot node helm chart

![Version: 5.0.0](https://img.shields.io/badge/Version-5.0.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)
![Version: 5.0.1](https://img.shields.io/badge/Version-5.0.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square)

## Maintainers

Expand Down
8 changes: 4 additions & 4 deletions charts/node/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ spec:
args:
- -c
- |
set -eu -o pipefail {{ if .Values.initContainers.persistGeneratedNodeKey.debug }}-x{{ end }}
set -eu {{ if .Values.initContainers.persistGeneratedNodeKey.debug }}-x{{ end }}
NODE_KEY_PATH="/keystore/node-key"
if [ -f "${NODE_KEY_PATH}" ]; then
echo "Node key already exists, skipping node key generation"
Expand All @@ -302,7 +302,7 @@ spec:
args:
- -c
- |
set -eu -o pipefail {{ if .Values.initContainers.injectKeys.debug }}-x{{ end }}
set -eu {{ if .Values.initContainers.injectKeys.debug }}-x{{ end }}
{{- range $keys := .Values.node.keys }}
if [ ! -f /var/run/secrets/{{ .type }}/type ]; then
echo "Error: File /var/run/secrets/{{ .type }}/type does not exist"
Expand Down Expand Up @@ -339,7 +339,7 @@ spec:
args:
- -c
- |
set -eu -o pipefail {{ if .Values.initContainers.injectKeys.debug }}-x{{ end }}
set -eu {{ if .Values.initContainers.injectKeys.debug }}-x{{ end }}
{{- range $keys := .Values.node.existingSecrets.keys }}
if [ ! -f /var/run/secrets/{{ $keys }}/type ]; then
echo "Error: File /var/run/secrets/{{ $keys }}/type does not exist"
Expand Down Expand Up @@ -372,7 +372,7 @@ spec:
args:
- -c
- |
set -eu -o pipefail {{ if .Values.initContainers.injectKeys.debug }}-x{{ end }}
set -eu {{ if .Values.initContainers.injectKeys.debug }}-x{{ end }}
{{- if .Values.node.vault.nodeKey }}
NODE_KEY_PATH="/vault/secrets/{{ .Values.node.vault.nodeKey.name }}{{ if .Values.node.vault.nodeKey.vaultKeyAppendPodIndex }}-${HOSTNAME##*-}{{ end }}"
if [ ! -f ${NODE_KEY_PATH} ]; then
Expand Down