forked from paritytech/polkadot-sdk
-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
frame-omni-bencher short checks (paritytech#5268)
- Part of paritytech/ci_cd#1006 - Closes: paritytech/ci_cd#1010 - Related: paritytech#4405 - Possibly affecting how frame-omni-bencher works on different runtimes: paritytech#5083 Currently works in parallel with gitlab short benchmarks. Triggered only by adding `GHA-migration` label to assure smooth transition (kind of feature-flag). Later when tested on random PRs we'll remove the gitlab and turn on by default these tests --------- Co-authored-by: Oliver Tale-Yazdi <[email protected]>
- Loading branch information
Showing
5 changed files
with
153 additions
and
66 deletions.
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,85 @@ | ||
| name: Short benchmarks (frame-omni-bencher) | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - master | ||
| pull_request: | ||
| types: [ opened, synchronize, reopened, ready_for_review, labeled ] | ||
| merge_group: | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }} | ||
| cancel-in-progress: true | ||
|
|
||
| env: | ||
| ARTIFACTS_NAME: frame-omni-bencher-artifacts | ||
|
|
||
| jobs: | ||
| changes: | ||
| # TODO: remove once migration is complete or this workflow is fully stable | ||
| if: contains(github.event.label.name, 'GHA-migration') | ||
| permissions: | ||
| pull-requests: read | ||
| uses: ./.github/workflows/reusable-check-changed-files.yml | ||
|
|
||
| set-image: | ||
| # GitHub Actions allows using 'env' in a container context. | ||
| # However, env variables don't work for forks: https://github.com/orgs/community/discussions/44322 | ||
| # This workaround sets the container image for each job using 'set-image' job output. | ||
| runs-on: ubuntu-latest | ||
| needs: changes | ||
| if: ${{ needs.changes.outputs.rust }} | ||
| outputs: | ||
| IMAGE: ${{ steps.set_image.outputs.IMAGE }} | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
| - id: set_image | ||
| run: cat .github/env >> $GITHUB_OUTPUT | ||
|
|
||
| run-frame-omni-bencher: | ||
| runs-on: arc-runners-polkadot-sdk-beefy | ||
| needs: [ set-image, changes ] # , build-frame-omni-bencher ] | ||
| if: ${{ needs.changes.outputs.rust }} | ||
| timeout-minutes: 30 | ||
| strategy: | ||
| fail-fast: false # keep running other workflows even if one fails, to see the logs of all possible failures | ||
| matrix: | ||
| runtime: | ||
| [ | ||
| westend-runtime, | ||
| rococo-runtime, | ||
| asset-hub-rococo-runtime, | ||
| asset-hub-westend-runtime, | ||
| bridge-hub-rococo-runtime, | ||
| bridge-hub-westend-runtime, | ||
| collectives-westend-runtime, | ||
| coretime-rococo-runtime, | ||
| coretime-westend-runtime, | ||
| people-rococo-runtime, | ||
| people-westend-runtime, | ||
| glutton-westend-runtime, | ||
| ] | ||
| container: | ||
| image: ${{ needs.set-image.outputs.IMAGE }} | ||
| env: | ||
| PACKAGE_NAME: ${{ matrix.runtime }} | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: script | ||
| run: | | ||
| RUNTIME_BLOB_NAME=$(echo $PACKAGE_NAME | sed 's/-/_/g').compact.compressed.wasm | ||
| RUNTIME_BLOB_PATH=./target/release/wbuild/$PACKAGE_NAME/$RUNTIME_BLOB_NAME | ||
| forklift cargo build --release --locked -p $PACKAGE_NAME -p frame-omni-bencher --features runtime-benchmarks | ||
| echo "Running short benchmarking for PACKAGE_NAME=$PACKAGE_NAME and RUNTIME_BLOB_PATH=$RUNTIME_BLOB_PATH" | ||
| ls -lrt $RUNTIME_BLOB_PATH | ||
| ./target/release/frame-omni-bencher v1 benchmark pallet --runtime $RUNTIME_BLOB_PATH --all --steps 2 --repeat 1 | ||
| confirm-frame-omni-benchers-passed: | ||
| runs-on: ubuntu-latest | ||
| name: All benchmarks passed | ||
| needs: run-frame-omni-bencher | ||
| steps: | ||
| - run: echo '### Good job! All the benchmarks passed 🚀' >> $GITHUB_STEP_SUMMARY |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,59 @@ | ||
| # Reusable workflow to perform checks and generate conditions for other workflows. | ||
| # Currently it checks if any Rust (build-related) file is changed | ||
| # and if the current (caller) workflow file is changed. | ||
| # Example: | ||
| # | ||
| # jobs: | ||
| # changes: | ||
| # permissions: | ||
| # pull-requests: read | ||
| # uses: ./.github/workflows/reusable-check-changed-files.yml | ||
| # some-job: | ||
| # needs: changes | ||
| # if: ${{ needs.changes.outputs.rust }} | ||
| # ....... | ||
|
|
||
| name: Check changes files | ||
|
|
||
| on: | ||
| workflow_call: | ||
| # Map the workflow outputs to job outputs | ||
| outputs: | ||
| rust: | ||
| value: ${{ jobs.changes.outputs.rust }} | ||
| description: "true if any of the build-related OR current (caller) workflow files have changed" | ||
| current-workflow: | ||
| value: ${{ jobs.changes.outputs.current-workflow }} | ||
| description: "true if current (caller) workflow file has changed" | ||
|
|
||
| jobs: | ||
| changes: | ||
| runs-on: ubuntu-latest | ||
| permissions: | ||
| pull-requests: read | ||
| outputs: | ||
| # true if current workflow (caller) file is changed | ||
| rust: ${{ steps.filter.outputs.rust == 'true' || steps.filter.outputs.current-workflow == 'true' }} | ||
| current-workflow: ${{ steps.filter.outputs.current-workflow }} | ||
| steps: | ||
| - id: current-file | ||
| run: echo "current-workflow-file=$(echo ${{ github.workflow_ref }} | sed -nE "s/.*(\.github\/workflows\/[a-zA-Z0-9_-]*\.y[a]?ml)@refs.*/\1/p")" >> $GITHUB_OUTPUT | ||
| - run: echo "${{ steps.current-file.outputs.current-workflow-file }}" | ||
| # For pull requests it's not necessary to checkout the code | ||
| - name: Checkout | ||
| if: github.event_name != 'pull_request' | ||
| uses: actions/checkout@v4 | ||
| - id: filter | ||
| uses: dorny/paths-filter@v3 | ||
| with: | ||
| predicate-quantifier: "every" | ||
| # current-workflow - check if the current (caller) workflow file is changed | ||
| # rust - check if any Rust (build-related) file is changed | ||
| filters: | | ||
| current-workflow: | ||
| - '${{ steps.current-file.outputs.current-workflow-file }}' | ||
| rust: | ||
| - '**/*' | ||
| - '!.github/**/*' | ||
| - '!prdoc/**/*' | ||
| - '!docs/**/*' |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters