Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a cmd to find error in _training_successful #591

Merged
merged 4 commits into from
Mar 1, 2024

Conversation

frcaud
Copy link
Collaborator

@frcaud frcaud commented Feb 29, 2024

Add a cmd to find error during check if training has been successful on the EC2 instance -> if error found then it returns false

@pep8speaks
Copy link

pep8speaks commented Feb 29, 2024

Hello @frcaud! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-03-01 10:23:52 UTC

Copy link
Collaborator

@rth rth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @frcaud . LGTM, but let's merge #592 first and sync here to fix CI.

Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.48%. Comparing base (a924439) to head (b4d696a).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #591   +/-   ##
=======================================
  Coverage   93.48%   93.48%           
=======================================
  Files         103      103           
  Lines        8991     8991           
=======================================
  Hits         8405     8405           
  Misses        586      586           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rth rth merged commit 52e5650 into paris-saclay-cds:master Mar 1, 2024
8 checks passed
@frcaud frcaud deleted the find_error branch March 1, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants