-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add delete-problem command to ramp-database #564
base: master
Are you sure you want to change the base?
Conversation
frcaud
commented
Feb 21, 2022
- add a delete_problem command to CLI of ramp-database
- infos corrections
Codecov Report
@@ Coverage Diff @@
## master #564 +/- ##
==========================================
- Coverage 93.51% 93.48% -0.03%
==========================================
Files 103 103
Lines 8944 8951 +7
==========================================
+ Hits 8364 8368 +4
- Misses 580 583 +3
Continue to review full report at Codecov.
|
Diff looks good. Can you just add a test and a what’s new entry ? 🙏 |
"iris", | ||
], | ||
catch_exceptions=False, | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any chance you can assess in the database that the problem is available after you add it and then gone once you remove it? see how it's done elsewhere.