Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add delete-problem command to ramp-database #564

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

frcaud
Copy link
Collaborator

@frcaud frcaud commented Feb 21, 2022

  • add a delete_problem command to CLI of ramp-database
  • infos corrections

@codecov
Copy link

codecov bot commented Feb 21, 2022

Codecov Report

Merging #564 (31cc2c3) into master (b29f0b4) will decrease coverage by 0.02%.
The diff coverage is 57.14%.

❗ Current head 31cc2c3 differs from pull request most recent head 24bdddc. Consider uploading reports for the commit 24bdddc to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #564      +/-   ##
==========================================
- Coverage   93.51%   93.48%   -0.03%     
==========================================
  Files         103      103              
  Lines        8944     8951       +7     
==========================================
+ Hits         8364     8368       +4     
- Misses        580      583       +3     
Impacted Files Coverage Δ
ramp-database/ramp_database/cli.py 95.63% <57.14%> (-1.10%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b29f0b4...24bdddc. Read the comment docs.

@frcaud frcaud changed the title add delete_problem command to ramp-database add delete-problem command to ramp-database Feb 21, 2022
@agramfort
Copy link
Collaborator

Diff looks good. Can you just add a test and a what’s new entry ? 🙏

"iris",
],
catch_exceptions=False,
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any chance you can assess in the database that the problem is available after you add it and then gone once you remove it? see how it's done elsewhere.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants