Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FrostDB for Parca #1278

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Update FrostDB for Parca #1278

merged 1 commit into from
Jun 30, 2022

Conversation

metalmatze
Copy link
Member

Copy link
Member

@kakkoyun kakkoyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like something wrong with the deps.

@metalmatze metalmatze force-pushed the frostdb-update branch 2 times, most recently from 2e54b8c to 09647b3 Compare June 30, 2022 14:25
@metalmatze
Copy link
Member Author

Since it was approved before and only rebased and force pushed, I enabled auto-merge ☺️

@kakkoyun kakkoyun disabled auto-merge June 30, 2022 16:03
@kakkoyun kakkoyun merged commit 906a3c2 into main Jun 30, 2022
@kakkoyun kakkoyun deleted the frostdb-update branch June 30, 2022 16:03
brancz added a commit that referenced this pull request Jun 30, 2022
@maxbrunet
Copy link
Member

FYI For simple updates like this one, you can check the box in the dependency dashboard and Renovate will take care of creating the PR and getting it merged

@metalmatze
Copy link
Member Author

FYI For simple updates like this one, you can check the box in the dependency dashboard and Renovate will take care of creating the PR and getting it merged

Nice. That's really good to know!
This one seems easier on the surface than it really was. I needed to update this locally and then also locally try if everything works! ☺️ In the end, it was still broken... 😂

@metalmatze
Copy link
Member Author

This issue is the "dependency dashboard"? Never used Renovate in-depth so I'm still learning about its features.

@maxbrunet
Copy link
Member

maxbrunet commented Jun 30, 2022

I needed to update this locally and then also locally try if everything works! ☺️ In the end, it was still broken... 😂

In ideal world, we should capture that in CI tests, easier said then done tho, maybe a step-by-step issue or doc would be a start

This issue is the "dependency dashboard"? Never used Renovate in-depth so I'm still learning about its features.

Yep! You can pin the issue if you want, so you always have it handy at the top

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants