Merge pull request #844 from parca-dev/stripEmptyNodes

pkg/query: Add stripEmptyNodes helper for flamegraphs

pkg/query/query.go

@@ -294,6 +294,7 @@ func (q *Query) renderReport(ctx context.Context, p profile.InstantProfile, typ
 		if err != nil {
 			return nil, status.Errorf(codes.Internal, "failed to generate flamegraph: %v", err.Error())
 		}
+		fg = stripEmptyNodes(fg)
 		return &pb.QueryResponse{
 			Report: &pb.QueryResponse_Flamegraph{
 				Flamegraph: fg,
@@ -326,6 +327,22 @@ func (q *Query) renderReport(ctx context.Context, p profile.InstantProfile, typ
 	}
 }
 
+// stripEmptyNodes iterates over all root children and only adds points to the children to the
+// nodes that actually have a non-zero cumulative value to the returned root children.
+// It's more a fix/hack than anything.
+// In the best case we don't even create the empty nodes to begin with when querying the storage.
+func stripEmptyNodes(fg *pb.Flamegraph) *pb.Flamegraph {
+	// Iterate over all root children and remove the once that have cumulative value == 0
+	children := make([]*pb.FlamegraphNode, 0, len(fg.Root.Children))
+	for _, child := range fg.Root.Children {
+		if child.Cumulative != 0 {
+			children = append(children, child)
+		}
+	}
+	fg.Root.Children = children
+	return fg
+}
+
 func (q *Query) findSingle(ctx context.Context, sel []*labels.Matcher, t time.Time) (profile.InstantProfile, error) {
 	requestedTime := timestamp.FromTime(t)
 

pkg/query/query_test.go

@@ -720,3 +720,33 @@ func Test_QueryRange_MultipleLabels_NoMatch(t *testing.T) {
 	require.NoError(t, err)
 	require.Equal(t, 0, len(resp.GetSeries()))
 }
+
+func Test_stripEmptyNodes(t *testing.T) {
+	original := &pb.Flamegraph{
+		Root: &pb.FlamegraphRootNode{
+			Cumulative: 7,
+			Children: []*pb.FlamegraphNode{
+				{Cumulative: 0},
+				{Cumulative: 1},
+				{Cumulative: 0},
+				{Cumulative: 2},
+				{Cumulative: 0},
+				{Cumulative: 4},
+				{Cumulative: 0},
+				{Cumulative: 0},
+			},
+		},
+	}
+	expected := &pb.Flamegraph{
+		Root: &pb.FlamegraphRootNode{
+			Cumulative: 7,
+			Children: []*pb.FlamegraphNode{
+				{Cumulative: 1},
+				{Cumulative: 2},
+				{Cumulative: 4},
+			},
+		},
+	}
+
+	require.Equal(t, expected, stripEmptyNodes(original))
+}