Skip to content

Fixed benchmark problems 10, 11, 48 #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

ytzi
Copy link
Contributor

@ytzi ytzi commented May 20, 2025

Summary of the changes:

  • Problem 10 and 11: Fixed how the convex hull is computed -- now lower hull computations are correct and the endpoints for the lower hull is not included (since they are also endpoints for the upper hull). Should Fix Functionally Incorrect Baseline : Geometry - Convex_hull_perimeter & Convex_hull #37 but I have not tested it extensively.
  • Problem 48: Should not clear the test vector after initialized it with a number of 0's.

@Dando18 Dando18 force-pushed the benchmark-problems-fix branch from c3912d3 to 0384ea3 Compare May 20, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Functionally Incorrect Baseline : Geometry - Convex_hull_perimeter & Convex_hull
1 participant