Skip to content

Functionally Incorrect Baseline : Geometry - Convex_hull_perimeter & Convex_hull #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aswinkumar1999 opened this issue Apr 9, 2025 · 0 comments · May be fixed by #52
Open

Functionally Incorrect Baseline : Geometry - Convex_hull_perimeter & Convex_hull #37

aswinkumar1999 opened this issue Apr 9, 2025 · 0 comments · May be fixed by #52

Comments

@aswinkumar1999
Copy link

Issues:

  • Incorrect Turn Condition: The condition used to pop points while building the upper hull is wrong (it keeps right turns instead of left turns).
  • Incorrect Lower Hull Logic: The loop structure and point access used to build the lower hull are fundamentally flawed and do not follow the algorithm's requirements.
  • Naive Merging: The upper and lower hulls are simply concatenated, which likely results in duplicated start/end points in the final hull list.

Test Example:

Testing with these set of points gives us incorrect results:

{0, 0}, {4, 0}, {4, 4}, {0, 4}, {2, 2}

Expected : 16 ( Square of side 4 )
Got : 13.6569

@aswinkumar1999 aswinkumar1999 changed the title Functional Incorrect Baseline : Geometry - Convex_hull_perimeter & Convex_hull Functionally Incorrect Baseline : Geometry - Convex_hull_perimeter & Convex_hull Apr 9, 2025
@ytzi ytzi linked a pull request May 20, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant