Bounce for withdraw、borrow 、repay #32
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfzhou5
commented
Jul 23, 2024
Comment on lines
+222
to
+239
| let queryId: Int = self.queryId; | ||
| let tokenTransferMsg: TokenTransfer = TokenTransfer{ | ||
| queryId: queryId, | ||
| amount: amount, | ||
| destination: toAddress, | ||
| response_destination: myAddress(), // Pool need to receive TokenExcesses message | ||
| custom_payload: null, | ||
| forward_ton_amount: 0, | ||
| forward_payload: emptySlice() | ||
| }; | ||
| // store TokenTransferBounce | ||
| let bounceMsg: TokenTransferBounce = TokenTransferBounce{ | ||
| to: poolWalletAddress, | ||
| user: toAddress, | ||
| msg: tokenTransferMsg | ||
| }; | ||
| self.tokenTransferMsg.set(queryId, bounceMsg); | ||
| self.queryId += 1; |
There was a problem hiding this comment.
如果下面的 gas value: ton("0.05") 设置的足够的话，这里可能就不需要做 Bounce处理
jfzhou5
commented
Jul 23, 2024
Comment on lines
+70
to
+74
| message MintBounce { | ||
| to: Address; | ||
| user: Address; | ||
| msg: Mint; | ||
| } |
There was a problem hiding this comment.
把 Bounce 类的 msg 结构固定了，to: to 地址，user：这个 message 对应的用户，msg: 原生message。
如何拿到 user对应的 bounce message，可能需要有个线下服务去定时扫一下 queryId 对应的 bounce message 内容。
i5possible
reviewed
Jul 24, 2024
| @@ -93,7 +95,7 @@ contract Pool with Deployable, Ownable, Resumable, PoolView { | |||
| let reserveAddress: Address = msg.tokenAddress; | |||
| let reserveConfiguration: ReserveConfiguration? = self.reservesConfiguration.get(reserveAddress); | |||
| require(reserveConfiguration != null, "Reserve not found"); | |||
|
|
|||
| // GetUserAccountData don't need do bounce | |||
There was a problem hiding this comment.
Suggested change
| // GetUserAccountData don't need do bounce | |
| // GetUserAccountData don't need to handle bounce | |
| or // GetUserAccountData won't bounce |
|
暂时不合，留着当后续参考 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.