Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: timelock whitelist #416

Merged
merged 10 commits into from
Sep 20, 2023
Merged

feat: timelock whitelist #416

merged 10 commits into from
Sep 20, 2023

Conversation

GopherJ
Copy link
Contributor

@GopherJ GopherJ commented Sep 8, 2023

Security Checklist

  • 1. Re-Entrancy
  • 2. Arithmetic Over/Under Flows
  • 3. Unexpected Ether
  • 4. Delegatecall
  • 5. Default Visibilities
  • 6. Entropy Illusion
  • 7. External Contract Referencing
  • 8. Short Address/Parameter Attack (off chain)
  • 9. Unchecked CALL Return Values
  • 10. Race Conditions / Front Running
  • 11. Denial Of Service (DOS)
  • 12. Block Timestamp Manipulation
  • 13. Constructors with Care
  • 14. Uninitialized Storage Pointers
  • 15. Floating Points and Precision
  • 16. Tx.Origin Authentication
  • 17. Address.isContract Re-Entrancy via Constructor

⚠️ NOTES ⚠️

Make sure to think about each of these exploits in this PR.

@GopherJ GopherJ requested a review from a team as a code owner September 8, 2023 15:14
@GopherJ GopherJ changed the title feat: init timelock whitelist feat: timelock whitelist Sep 12, 2023
@GopherJ GopherJ merged commit 2aa2ecd into main Sep 20, 2023
2 of 4 checks passed
@GopherJ GopherJ deleted the feat/timelock-whitelist branch September 20, 2023 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhoujia6139 zhoujia6139 zhoujia6139 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GopherJ @zhoujia6139