Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: account delegation implementation #410

Merged
merged 11 commits into from
Sep 5, 2023
Merged

feat: account delegation implementation #410

merged 11 commits into from
Sep 5, 2023

Conversation

WalidOfNow
Copy link
Contributor

Security Checklist

  • 1. Re-Entrancy
  • 2. Arithmetic Over/Under Flows
  • 3. Unexpected Ether
  • 4. Delegatecall
  • 5. Default Visibilities
  • 6. Entropy Illusion
  • 7. External Contract Referencing
  • 8. Short Address/Parameter Attack (off chain)
  • 9. Unchecked CALL Return Values
  • 10. Race Conditions / Front Running
  • 11. Denial Of Service (DOS)
  • 12. Block Timestamp Manipulation
  • 13. Constructors with Care
  • 14. Uninitialized Storage Pointers
  • 15. Floating Points and Precision
  • 16. Tx.Origin Authentication
  • 17. Address.isContract Re-Entrancy via Constructor

⚠️ NOTES ⚠️

Make sure to think about each of these exploits in this PR.

@WalidOfNow WalidOfNow requested a review from a team as a code owner August 30, 2023 22:24
GopherJ
GopherJ previously approved these changes Aug 31, 2023
View reviewed changes
@GopherJ GopherJ self-requested a review August 31, 2023 12:48
GopherJ
GopherJ previously approved these changes Aug 31, 2023
View reviewed changes
@GopherJ GopherJ self-requested a review September 5, 2023 01:31
@GopherJ GopherJ merged commit 6faba91 into main Sep 5, 2023
1 of 4 checks passed
@GopherJ GopherJ deleted the account-delegation branch September 5, 2023 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GopherJ GopherJ GopherJ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WalidOfNow @GopherJ @zhoujia6139