Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/cleanup #408

Merged
merged 42 commits into from
Aug 30, 2023
Merged

Chore/cleanup #408

merged 42 commits into from
Aug 30, 2023

Conversation

GopherJ
Copy link
Contributor

@GopherJ GopherJ commented Aug 30, 2023

Security Checklist

  • 1. Re-Entrancy
  • 2. Arithmetic Over/Under Flows
  • 3. Unexpected Ether
  • 4. Delegatecall
  • 5. Default Visibilities
  • 6. Entropy Illusion
  • 7. External Contract Referencing
  • 8. Short Address/Parameter Attack (off chain)
  • 9. Unchecked CALL Return Values
  • 10. Race Conditions / Front Running
  • 11. Denial Of Service (DOS)
  • 12. Block Timestamp Manipulation
  • 13. Constructors with Care
  • 14. Uninitialized Storage Pointers
  • 15. Floating Points and Precision
  • 16. Tx.Origin Authentication
  • 17. Address.isContract Re-Entrancy via Constructor

⚠️ NOTES ⚠️

Make sure to think about each of these exploits in this PR.

WalidOfNow and others added 30 commits July 20, 2023 18:37
@WalidOfNow
feat: adds initial account abstraction implementation
7f56655
@WalidOfNow
feat: adds the ParaAccount and complete the initial functionality
e2381eb
@WalidOfNow
feat: a working version with ERC721 verification
a900e9e
@GopherJ
feat: initialize migration
edd3fa1 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
feat: support different recipient address
06aa92e 
Signed-off-by: GopherJ <[email protected]>
@WalidOfNow
feat: refactor account abstraction to a simple one
4f1b32a
@WalidOfNow
feat: remove not needed contracts
d2e4d62
@WalidOfNow
feat: remove not needed contracts
e5d53b4
@WalidOfNow
chore: adds tests for AA
3fe6c94
@WalidOfNow
chore: adds account address to the accountCreated event
c241915
@WalidOfNow
chore: adds AA deployment step
8485fee
@WalidOfNow
chore: adds test for account upgrade
7f4f368
@WalidOfNow
chore: adds values array to executeBatch
287f51b
@GopherJ
fix: aa must belong to user
78496b4 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
chore: tiny optimization
65ed8f2 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
chore: revert unecessary changes
466eeb3 
Signed-off-by: GopherJ <[email protected]>
@WalidOfNow
chore: adds ERC1271 comp
287c70d
@WalidOfNow
chore: remove signature encoding for contracts
9d24e3d
@zhoujia6139
chore: replace signature checker.
9512a95
@GopherJ
fix: hvmtl supplycap
6858a22 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
feat: update admin account
df59d6f 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
fix: add missing claimMoonbirds
0e4b462 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
chore: update config
4224b1d 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
chore: add more aggregators
f330321 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
chore: add more aggregators
fe79dc8 
Signed-off-by: GopherJ <[email protected]>
@WalidOfNow
chore: fixes owner.code
d0e7c96
@GopherJ
chore: add missing items
46eddec 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
chore: improve
4f6bc97 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
chore: catch error
8b721a5 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
fix: revert for usdt
ba1acbe 
Signed-off-by: GopherJ <[email protected]>
GopherJ and others added 12 commits August 23, 2023 14:28
@GopherJ
fix: verification
ff6610e 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
Merge branch 'main' into account-abstraction
3a6d53c
@GopherJ
Merge remote-tracking branch 'origin/account-abstraction' into feat/m…
2e866eb 
…igration
@GopherJ
fix: lint
6258ac5 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
chore: revert modification
fea1143 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
Merge remote-tracking branch 'origin/main' into feat/migration
2500dab
@GopherJ
fix: typo
13fd6cf 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
feat: support rescueETH
05a0446 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
fix: partial lint errors
453681b 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
chore: add migration audit report
c693639 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
chore: rename
cc03eb0 
Signed-off-by: GopherJ <[email protected]>
@GopherJ
feat: cleanup & add audit report
a63f732 
Signed-off-by: GopherJ <[email protected]>
@GopherJ GopherJ requested a review from a team as a code owner August 30, 2023 06:43
@GopherJ GopherJ merged commit 73cbb39 into main Aug 30, 2023
1 of 4 checks passed
@GopherJ GopherJ deleted the chore/cleanup branch August 30, 2023 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhoujia6139 zhoujia6139 zhoujia6139 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GopherJ @zhoujia6139 @WalidOfNow