Parax nft #405
Closed
Parax nft #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GopherJ
previously approved these changes
Aug 30, 2023
GopherJ
reviewed
Aug 30, 2023
helpers/contracts-deployments.ts
Outdated
| verify | ||
| ); | ||
|
|
||
| const proxyAdmin = "0x17816E9A858b161c3E37016D139cf618056CaCD4"; //yubo.eth |
There was a problem hiding this comment.
might better be our safe address? 0x19293FBec52F94165f903708a74513Dd6dFedd0a
There was a problem hiding this comment.
It's a one-time deploy contract and yubo ask use his addrss as proxy admin
GopherJ
reviewed
Aug 30, 2023
test/_parax_spec.ts
Outdated
| expect(await ParaX.totalSupply()).to.be.eq(4); | ||
|
|
||
| expect(await getProxyAdmin(ParaX.address)).to.be.eq( | ||
| "0x17816E9A858b161c3E37016D139cf618056CaCD4" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Security Checklist
Make sure to think about each of these exploits in this PR.