Izumi lp integration #402
Open
Izumi lp integration #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
billyz9611
reviewed
Aug 21, 2023
| amount1Min | ||
| ); | ||
|
|
||
| // refund unused tokens |
There was a problem hiding this comment.
if token0 & token1 are not WETH, we need to refund ETH to user when msg.value > 0.
GopherJ
reviewed
Sep 5, 2023
| require(token0 == weth || token1 == weth, Errors.INVALID_AMOUNT); | ||
| token0IsETH = (token0 == weth); | ||
| token1IsETH = (token1 == weth); | ||
| } |
There was a problem hiding this comment.
there are many duplicated code here, I think we can declare variable to represent ethToken, ethAmount
GopherJ
reviewed
Sep 5, 2023
| } else { | ||
| IERC20(token0).safeTransfer(payer, refund0); | ||
| } | ||
| } |
There was a problem hiding this comment.
same here I think we can remove duplicated code
|
I think upgrade script should also be fixed by adding Izumi LP |
GopherJ
reviewed
Sep 5, 2023
| @@ -25,6 +25,7 @@ enum XTokenType { | |||
| NTokenOtherdeed, | |||
| NTokenStakefish, | |||
| NTokenChromieSquiggle, | |||
| NTokenIZUMILp, | |||
There was a problem hiding this comment.
this will break PTokenStKSM which is deployed on moonbeam
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Security Checklist
Make sure to think about each of these exploits in this PR.