Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept underlying bids from Blur #390

Merged
merged 8 commits into from
Oct 10, 2023
Merged

Accept underlying bids from Blur #390

merged 8 commits into from
Oct 10, 2023

Conversation

zhoujia6139
Copy link
Contributor

Security Checklist

  • 1. Re-Entrancy
  • 2. Arithmetic Over/Under Flows
  • 3. Unexpected Ether
  • 4. Delegatecall
  • 5. Default Visibilities
  • 6. Entropy Illusion
  • 7. External Contract Referencing
  • 8. Short Address/Parameter Attack (off chain)
  • 9. Unchecked CALL Return Values
  • 10. Race Conditions / Front Running
  • 11. Denial Of Service (DOS)
  • 12. Block Timestamp Manipulation
  • 13. Constructors with Care
  • 14. Uninitialized Storage Pointers
  • 15. Floating Points and Precision
  • 16. Tx.Origin Authentication
  • 17. Address.isContract Re-Entrancy via Constructor

⚠️ NOTES ⚠️

Make sure to think about each of these exploits in this PR.

@zhoujia6139 zhoujia6139 requested a review from a team as a code owner May 25, 2023 01:42
@zhoujia6139 zhoujia6139 changed the title chore: basic implementation for BLUR sell Accept underlying bids from Blur May 25, 2023
@zhoujia6139 zhoujia6139 force-pushed the accept_underlying_bids_from_blur branch from 17ca359 to 3a01c2b Compare May 31, 2023 02:51
@zhoujia6139 zhoujia6139 merged commit 43cb9a8 into blur_integration Oct 10, 2023
1 of 4 checks passed
@zhoujia6139 zhoujia6139 deleted the accept_underlying_bids_from_blur branch October 10, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xrjman 0xrjman 0xrjman left review comments

@billyz9611 billyz9611 billyz9611 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhoujia6139 @billyz9611 @0xrjman