Update bindgen #159
Update bindgen #159
Conversation
| At the moment we use test and support the following Rust compiler versions: | ||
|
|
||
| * On Ubuntu we test with the latest stable compiler version, as accessible through `rustup`. | ||
| * On Fedora we test with the compiler version included with the Fedora 33 release. |
There was a problem hiding this comment.
Do we test with the latest compiler version available in Fedora 33?
There was a problem hiding this comment.
I think we test with the one that comes with the OS release? CC @puiterwijk
There was a problem hiding this comment.
Yes, we test with the one that's included in Fedora 33.
| * On Ubuntu we test with the latest stable compiler version, as accessible through `rustup`. | ||
| * On Fedora we test with the compiler version included with the Fedora 33 release. | ||
|
|
||
| If you need support for other versions of the compiler, get in touch with us to see what we can do! |
There was a problem hiding this comment.
Maybe mention somewhere that for those supproted versions we test on the CI that every PR works with them.
There was a problem hiding this comment.
I made a mistake on the line before the list above, will include it there.
There was a problem hiding this comment.
I was under the impression that we would use the packaged versions for the different distributions so in the case of ubuntu one would need to do the following: apt update && apt -y upgrade && apt install rustc && apt install cargo. So that we could say that we support the latest version that the distribution provides using its update channels.
There was a problem hiding this comment.
In the Dockerfile we actually build with the pipe-to-shell command from the Rust website - but that's a good point, maybe we should try out the one included in Ubuntu.
There was a problem hiding this comment.
It seems the latest supported is 1.43.0 (for rustc), but the weird thing is that cargo has version 0.44.1 🤔
There was a problem hiding this comment.
I was under the impression that we would use the packaged versions for the different distributions
I think we decided that as well for all the distributions that we want to support (like Fedora) but I think we should also definitely test with the latest stable Rust got from rustup. If Ubuntu is also one of the distribution we want to support then we should do the three:
- Ubuntu using the latest version of
cargofromapt - Fedora using the latest version of
cargofromdnf - any distrib using the latest version from
rustup
My point being that for the case when we test on rustup, the distribution should not really matter.
Signed-off-by: Fabio Valentini <[email protected]>
Signed-off-by: Ionut Mihalcea <[email protected]>
ionut-arm
force-pushed
the
update-bindgen
branch
from
aefa978 to
c892c2d
Compare
Update partners file with web links and logos
This uses the commit in #154 and removes the dependency on 1.38.0 and nightly.
If there is any other requirement that I forgot about, let me know.