Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tracer): no whitespace at the end of a line #252

Merged
merged 5 commits into from
Jan 13, 2025

Conversation

jsvisa
Copy link
Contributor

@jsvisa jsvisa commented Jan 13, 2025

As some code editer will auto trim the ending whitespace, like below:

image

So when we're editing some testcases(eg: in the foundry project), it's annoyed for me to edit the test file, so I propose remove the ending backspace for the trace writer.

Copy link
Contributor

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

pending @DaniPopes

Copy link
Member

@DaniPopes DaniPopes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair

@DaniPopes DaniPopes merged commit 07724e6 into paradigmxyz:main Jan 13, 2025
9 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants