Skip to content

chore(reth-primitives): no_std support #9598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

martinezjorge
Copy link
Contributor

Helps progress #9478

@martinezjorge
Copy link
Contributor Author

martinezjorge commented Jul 18, 2024

This was meant to be a draft PR. Still have to get all the tests to pass, but any feedback on the current changes would be greatly appreciated.

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this

I believe with #9556 this is now actually completed.
sorry for sniping this...

@martinezjorge
Copy link
Contributor Author

martinezjorge commented Jul 18, 2024

Oh ok, no worries. I'll study what you did to learn.

@nkysg
Copy link
Contributor

nkysg commented Jul 22, 2024

thanks for this

I believe with #9556 this is now actually completed. sorry for sniping this...

I think #9556 not completed. I run cmd

 cargo c --no-default-features -p reth-primitives
    Checking reth-primitives v1.0.3 (/Users/YSG/Github/reth/crates/primitives)
error[E0433]: failed to resolve: use of undeclared crate or module `std`
 --> crates/primitives/src/transaction/error.rs:7:1
  |
7 | pub enum InvalidTransactionError {
  | ^^^ use of undeclared crate or module `std`
  |
help: consider importing this module
  |
1 + use core::error;
  |

error[E0433]: failed to resolve: use of undeclared crate or module `std`
  --> crates/primitives/src/transaction/error.rs:63:1
   |
63 | pub enum TransactionConversionError {
   | ^^^ use of undeclared crate or module `std`
   |
help: consider importing this module
   |
1  + use core::error;

Please take a look at @mattsse . Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants