Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(rpc-builder): support jwt secret in client #5284

Merged
merged 8 commits into from
Nov 4, 2023

Conversation

DoTheBestToGetTheBest
Copy link
Contributor

No description provided.

@mattsse mattsse changed the title feat(rpc-builder) feat(rpc-builder): support jwt secret in client Nov 3, 2023
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great start,

we also want a sanity test for this

crates/rpc/rpc-builder/src/lib.rs Outdated Show resolved Hide resolved
crates/rpc/rpc-builder/src/lib.rs Outdated Show resolved Hide resolved
@DoTheBestToGetTheBest
Copy link
Contributor Author

great start,

Ty lot, this is thanks to your advice ! Ty so much

we also want a sanity test for this

not sure if i can do test since i can't bulid and run test in my current pc

i could do something totally wrong or something

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@mattsse mattsse added this pull request to the merge queue Nov 4, 2023
Merged via the queue into paradigmxyz:main with commit 2412cc4 Nov 4, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants