feat: validate empty execution requests for OP #13980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rjected
reviewed
Jan 24, 2025
crates/optimism/node/src/engine.rs
Outdated
| // according to op spec, execution requests must be empty | ||
| if !requests.is_empty() { | ||
| return Err(EngineObjectValidationError::InvalidParams( | ||
| "non-empty execution requests".to_string().into(), |
There was a problem hiding this comment.
Can we make this match the style of the other error messages?
eg, camel case
"MissingGasLimitInPayloadAttributes".to_string().into(),There was a problem hiding this comment.
fixed, should we also update these? https://github.com/meyer9/reth/blob/0b4a0dbb10fcb8a405c155cdb6ac058e8813a52d/crates/payload/primitives/src/lib.rs#L386
CodSpeed Performance ReportMerging #13980 will degrade performances by 10.39%Comparing Summary
Benchmarks breakdown
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures that execution requests array is empty for Optimism. Fixes #13908