Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(util): Add reth payload util #12590

Merged
merged 5 commits into from
Nov 16, 2024

Conversation

TheDhejavu
Copy link
Contributor

Resolves: #12533

  • Added a new reth-payload-util crate within the payload module that contains shared utilities, allowing transaction-pool to use these utilities without creating dependency cycles.
  • I also discovered that many components are tightly coupled with the transaction pool module, which explains the concentration of changes there. We should consider refactoring the transaction pool to better separate concerns, especially for functionality that could be reused elsewhere without creating dependency cycles.

For example, this code remains in transaction pool due to its dependencies:

pub struct BestPayloadTransactions<T, I>

Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good first step, I'm fine with inverting the dependency and move more txpool related things to payload-util

@mattsse mattsse added this pull request to the merge queue Nov 16, 2024
@mattsse mattsse added the A-block-building Related to block building label Nov 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 16, 2024
@mattsse mattsse merged commit 5276093 into paradigmxyz:main Nov 16, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-block-building Related to block building
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extract PayloadTransactions to payload-primitives
2 participants