chore(sdk): improve usability block primitive traits

crates/e2e-test-utils/src/engine_api.rs

@@ -55,8 +55,7 @@ impl<E: EngineTypes, ChainSpec: EthereumHardforks> EngineApiTestContext<E, Chain
         E::ExecutionPayloadEnvelopeV3: From<E::BuiltPayload> + PayloadEnvelopeExt,
         E::ExecutionPayloadEnvelopeV4: From<E::BuiltPayload> + PayloadEnvelopeExt,
     {
-        let versioned_hashes =
-            payload.block().blob_versioned_hashes_iter().copied().collect::<Vec<_>>();
+        let versioned_hashes = payload.block().blob_versioned_hashes_copied();
         // submit payload to engine api
         let submission = if self
             .chain_spec

crates/net/eth-wire-types/src/primitives.rs

@@ -3,7 +3,7 @@
 use std::fmt::Debug;
 
 use alloy_rlp::{Decodable, Encodable};
-use reth_primitives_traits::{Block, BlockHeader};
+use reth_primitives_traits::{Block, BlockBody, BlockHeader};
 
 /// Abstraction over primitive types which might appear in network messages. See
 /// [`crate::EthMessage`] for more context.
@@ -23,7 +23,8 @@ pub trait NetworkPrimitives:
         + Eq
         + 'static;
     /// The block body type.
-    type BlockBody: Encodable
+    type BlockBody: BlockBody<Header = Self::BlockHeader>
+        + Encodable
         + Decodable
         + Send
         + Sync

crates/optimism/primitives/Cargo.toml

@@ -12,21 +12,33 @@ description = "OP primitive types"
 workspace = true
 
 [dependencies]
+# reth
+reth-primitives-traits.workspace = true
+reth-codecs = { workspace = true, optional = true }
+reth-primitives = { workspace = true, features = ["reth-codec"], optional = true }
+
+# ethereum
 alloy-primitives.workspace = true
 alloy-consensus.workspace = true
-op-alloy-consensus.workspace = true
 alloy-eips.workspace = true
 alloy-rlp.workspace = true
-derive_more.workspace = true
+
+# op
+op-alloy-consensus.workspace = true
+
+# codec
 bytes.workspace = true
-reth-primitives-traits.workspace = true
-reth-codecs = { workspace = true, optional = true }
-reth-primitives = { workspace = true, features = ["reth-codec"], optional = true }
 
-[features]
-default = ["reth-codec"]
-reth-codec = ["dep:reth-codecs", "dep:reth-primitives"]
+# misc
+derive_more.workspace = true
 
 [dev-dependencies]
 reth-codecs = { workspace = true, features = ["test-utils"] }
-rstest.workspace = true
+rstest.workspace = true
+
+[features]
+default = ["reth-codec"]
+reth-codec = [
+    "dep:reth-codecs",
+    "dep:reth-primitives",
+]

crates/payload/validator/src/lib.rs

@@ -64,7 +64,8 @@ impl<ChainSpec: EthereumHardforks> ExecutionPayloadValidator<ChainSpec> {
         sealed_block: &SealedBlock,
         cancun_fields: &MaybeCancunPayloadFields,
     ) -> Result<(), PayloadError> {
-        let num_blob_versioned_hashes = sealed_block.blob_versioned_hashes_iter().count();
+        let blob_versioned_hashes = sealed_block.blob_versioned_hashes();
+        let num_blob_versioned_hashes = blob_versioned_hashes.len();
         // Additional Cancun checks for blob transactions
         if let Some(versioned_hashes) = cancun_fields.versioned_hashes() {
             if num_blob_versioned_hashes != versioned_hashes.len() {
@@ -73,9 +74,9 @@ impl<ChainSpec: EthereumHardforks> ExecutionPayloadValidator<ChainSpec> {
             }
             // we can use `zip` safely here because we already compared their length
             for (payload_versioned_hash, block_versioned_hash) in
-                versioned_hashes.iter().zip(sealed_block.blob_versioned_hashes_iter())
+                versioned_hashes.iter().zip(blob_versioned_hashes.iter())
             {
-                if payload_versioned_hash != block_versioned_hash {
+                if payload_versioned_hash != *block_versioned_hash {
                     return Err(PayloadError::InvalidVersionedHashes)
                 }
             }

crates/primitives-traits/Cargo.toml

@@ -14,24 +14,28 @@ workspace = true
 [dependencies]
 reth-codecs.workspace = true
 
+# ethereum
 alloy-consensus = { workspace = true, features = ["serde"] }
 alloy-eips.workspace = true
 alloy-genesis.workspace = true
 alloy-primitives.workspace = true
 alloy-rlp.workspace = true
-
 revm-primitives = { workspace = true, features = ["serde"] }
 
-# misc
+# io
+rayon.workspace = true
+
+# codec
 byteorder = "1"
-derive_more.workspace = true
 roaring = "0.10.2"
+serde.workspace = true
 serde_with = { workspace = true, optional = true }
-
-# required by reth-codecs
 bytes.workspace = true
 modular-bitfield.workspace = true
-serde.workspace = true
+
+# misc
+derive_more.workspace = true
+once_cell.workspace = true
 
 # arbitrary utils
 arbitrary = { workspace = true, features = ["derive"], optional = true }
@@ -57,7 +61,8 @@ std = [
 	"alloy-genesis/std",
 	"alloy-primitives/std",
 	"revm-primitives/std",
-	"serde/std"
+	"serde/std",
+	"once_cell/std",
 ]
 test-utils = [
 	"arbitrary",