chore(sdk): integrate generic receipt into execution #12397
Conversation
emhane
added
C-debt
emhane
force-pushed
the
emhane/integrate-generic-receipt-execution
branch
from
2c4f8f3
to
05d2941
Compare
crates/primitives/src/lib.rs
Outdated
|
|
||
| /// Temp helper struct for integrating [`NodePrimitives`](reth_primitives_traits::NodePrimitives). | ||
| #[derive(Debug, Clone, Default)] | ||
| pub struct AnyPrimitives; | ||
|
|
||
| impl reth_primitives_traits::NodePrimitives for AnyPrimitives { | ||
| type Block = crate::Block; | ||
| type BlockHeader = alloy_consensus::Header; | ||
| type BlockBody = crate::BlockBody; | ||
| type SignedTx = crate::TransactionSigned; | ||
| type TxType = crate::TxType; | ||
| type Receipt = crate::Receipt; | ||
| } |
There was a problem hiding this comment.
we needed to access them in the code already generalised by arseni
emhane
force-pushed
the
emhane/integrate-generic-receipt-execution
branch
from
adff3ef
to
53c8a2f
Compare
…om:paradigmxyz/reth into emhane/integrate-generic-receipt-execution
| #[derive(Debug, Clone, Default, PartialEq, Eq)] | ||
| pub struct AnyPrimitives; | ||
|
|
||
| impl reth_primitives_traits::NodePrimitives for AnyPrimitives { |
There was a problem hiding this comment.
I think it makes sense to just use EthPrimitives for this?
There was a problem hiding this comment.
the reason I made AnyPrimitives, is so that we can replace type by type inside EthPrimitives and OpPrimitives, component by component, and don't have to wait till we can replace a type on EthPrimitives and OpPrimitives across all components at the same time
There was a problem hiding this comment.
we can replace type by type inside
EthPrimitives
wdym? I'd expect EthPrimitives to be the same as right now (besides transaction type being changed eventually). so given that AnyPrimitives are same as EthPrimitives right now this would probably hold?
Ref #12358