Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(db): use Into to encode StoredNibbles #11350

Merged
merged 2 commits into from
Sep 30, 2024
Merged

perf(db): use Into to encode StoredNibbles #11350

merged 2 commits into from
Sep 30, 2024
+4 −4

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Sep 30, 2024 •
edited
Loading

See comment

This can be &[u8] directly with #11186

@DaniPopes DaniPopes requested review from mattsse and onbjerg and removed request for rakita and joshieDo September 30, 2024 17:30
Rjected
Rjected approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@Rjected Rjected left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DaniPopes DaniPopes added this pull request to the merge queue Sep 30, 2024
Merged via the queue into main with commit 68f0b0a Sep 30, 2024
35 checks passed
@DaniPopes DaniPopes deleted the dani/perf-StoredNibbles branch September 30, 2024 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rjected Rjected Rjected approved these changes

@mattsse mattsse Awaiting requested review from mattsse

@onbjerg onbjerg Awaiting requested review from onbjerg

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @Rjected