Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract block executor output #11314

Closed
wants to merge 10 commits into from
Closed

Abstract block executor output #11314

wants to merge 10 commits into from

Conversation

emhane
Copy link
Member

@emhane emhane commented Sep 28, 2024

Closes #11108

  • Removes optimism feature from reth-auto-seal-consensus.
  • Defines trait BlockExecOutput, and removes constraint of specific type BlockExecutionOutput off Executor::Output.
  • Adds trait method BlockExecOutput::receipts_root_slow.
  • Allows configuring network specific receipts root calculation at sdk level without adding another associated type to NodeAddOns, by sensibly configuring it as part of the existing block executor component.

@emhane emhane marked this pull request as draft September 28, 2024 15:51
@emhane emhane mentioned this pull request Sep 28, 2024
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does BlockExecutorProvider::Executor have to have GAT for db? it's a blocker, since it isn't yet stable to do

impl<A, B> BlockExecutorProvider for Either<A, B>
where
    A: BlockExecutorProvider,
    B: for<DB> BlockExecutorProvider<
        Executor<DB>: Executor<DB, Output = <A::Executor<DB> as Executor<DB>>::Output>,
    >,

@mattsse

@emhane emhane marked this pull request as ready for review October 1, 2024 15:17
@emhane emhane added S-blocked This cannot more forward until something else changes A-op-reth Related to Optimism and op-reth A-sdk Related to reth's use as a library A-execution Related to the Execution and EVM labels Oct 1, 2024
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this drifted too much and was premature, we need to tackle this differently after we have a way to customize block types

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-execution Related to the Execution and EVM A-op-reth Related to Optimism and op-reth A-sdk Related to reth's use as a library S-blocked This cannot more forward until something else changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make ExecutionOutcome generic over receipt collection type
2 participants