-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Abstract block executor output #11314
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does BlockExecutorProvider::Executor
have to have GAT for db? it's a blocker, since it isn't yet stable to do
impl<A, B> BlockExecutorProvider for Either<A, B>
where
A: BlockExecutorProvider,
B: for<DB> BlockExecutorProvider<
Executor<DB>: Executor<DB, Output = <A::Executor<DB> as Executor<DB>>::Output>,
>,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this drifted too much and was premature, we need to tackle this differently after we have a way to customize block types
Closes #11108
reth-auto-seal-consensus
.BlockExecOutput
, and removes constraint of specific typeBlockExecutionOutput
offExecutor::Output
.BlockExecOutput::receipts_root_slow
.NodeAddOns
, by sensibly configuring it as part of the existing block executor component.