fix: improve ecies error fatal variants #11303
Merged
+28
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caglaryucekaya
requested review from
emhane,
mattsse and
Rjected
as code owners
caglaryucekaya
force-pushed
the
improve-ecies-error
branch
from
9430119
to
59382a4
Compare
Rjected
previously requested changes
Sep 27, 2024
caglaryucekaya
force-pushed
the
improve-ecies-error
branch
from
59382a4
to
e1c6e43
Compare
…prove-ecies-error
mattsse
approved these changes
Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #11259
Which error variants should be fatal needs to be reviewed.