Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove generics from Decode and Decompress #11295

Merged
merged 2 commits into from
Sep 27, 2024
Merged

chore: remove generics from Decode and Decompress #11295

merged 2 commits into from
Sep 27, 2024

Conversation

DaniPopes
Copy link
Member

@DaniPopes DaniPopes commented Sep 27, 2024 •
edited
Loading

And add decode_owned to match decompress_owned.

There is no benefit of accepting AsRef<[u8]> rather than &[u8] directly, and instead only makes code size and compilation times worse.

mattsse
mattsse reviewed Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

function changes lgtm,

didn't look at the changed key logic, can we do that separately?

crates/storage/db-api/src/models/sharded_key.rs Show resolved Hide resolved
@mattsse mattsse added C-perf A change motivated by improving speed, memory usage or disk footprint A-db Related to the database labels Sep 27, 2024
mattsse
mattsse approved these changes Sep 27, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

crates/storage/db-api/src/models/sharded_key.rs Show resolved Hide resolved
@DaniPopes DaniPopes added this pull request to the merge queue Sep 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 27, 2024
@DaniPopes DaniPopes added this pull request to the merge queue Sep 27, 2024
Merged via the queue into main with commit 50265b1 Sep 27, 2024
35 checks passed
@DaniPopes DaniPopes deleted the dani/decode-generics branch September 27, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@joshieDo joshieDo Awaiting requested review from joshieDo joshieDo is a code owner

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@shekhirin shekhirin Awaiting requested review from shekhirin shekhirin is a code owner

Assignees
No one assigned
Labels
A-db Related to the database C-perf A change motivated by improving speed, memory usage or disk footprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniPopes @mattsse