feat(exex): add parent hash to WAL block cache, index by hashes #11263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shekhirin
added
C-enhancement
mattsse
approved these changes
Sep 27, 2024
| /// | ||
| /// For each [`ExExNotification::ChainCommitted`] notification, there will be an entry per | ||
| /// block. | ||
| blocks: DashMap<B256, CachedBlock>, |
There was a problem hiding this comment.
looks like we only access this for insert rn.
DashMap seems fine here, alternatively a rwlock would also work
There was a problem hiding this comment.
yes, and we will later access it when reading the WAL from ExExNotificationsWIthHead.
yeah, an RwLock would be easier, so we can have the whole BlockCache behind it, and not just one field inside
There was a problem hiding this comment.
hmm actually no, we will have only blocks field in the future so it's fine to have a dashmap here #11266 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11258