Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(evm): replace reth-primitives with alloy #11232

Merged
merged 2 commits into from
Sep 26, 2024
Merged

chore(evm): replace reth-primitives with alloy #11232

merged 2 commits into from
Sep 26, 2024

Conversation

Abhishekkochar
Copy link
Contributor

Progress on #10749

@Abhishekkochar
Fixed clippy - cartes/engine
8ced4c6 
Signed-off-by: Abhishekkochar <[email protected]>
Abhishekkochar
Abhishekkochar commented Sep 26, 2024
View reviewed changes
Copy link
Contributor Author

@Abhishekkochar Abhishekkochar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mattsse @onbjerg There are no changes being made in crates other than engine and evm. Lint is currently failing in rpc crate.

mattsse
mattsse approved these changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

clippy unrelated

@mattsse mattsse merged commit 20d6950 into paradigmxyz:main Sep 26, 2024
34 of 36 checks passed
@mattsse mattsse added the A-dependencies Pull requests or issues that are about dependencies label Sep 26, 2024
@Abhishekkochar Abhishekkochar deleted the ak/evm branch September 26, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@rakita rakita Awaiting requested review from rakita rakita is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@rkrasiuk rkrasiuk Awaiting requested review from rkrasiuk rkrasiuk is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

Assignees
No one assigned
Labels
A-dependencies Pull requests or issues that are about dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Abhishekkochar @mattsse