Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(op): unify crate name reth-optimism-* #11223

Merged
merged 2 commits into from
Sep 28, 2024
Merged

chore(op): unify crate name reth-optimism-* #11223

merged 2 commits into from
Sep 28, 2024

Conversation

nkysg
Copy link
Contributor

@nkysg nkysg commented Sep 25, 2024 •
edited
Loading

most optimism crate name are reth-optimism-* except reth-evm-optimism and reth-node-optimism. This just unify using reth-optimism-*

@emhane
Copy link
Member

emhane commented Sep 26, 2024

I prefer op-reth tbh @mattsse , we talked ab it some time back, wdyt?

mattsse
mattsse requested changes Sep 26, 2024
View reviewed changes
Copy link
Collaborator

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this, this makes it consistent with the other components.

we can do the same for ethereum.

.github/assets/check_wasm.sh Outdated Show resolved Hide resolved
@nkysg nkysg requested a review from mattsse September 27, 2024 00:08
@mattsse mattsse added this pull request to the merge queue Sep 28, 2024
Merged via the queue into paradigmxyz:main with commit 375acdf Sep 28, 2024
37 checks passed
@nkysg nkysg deleted the op_unify_name branch September 28, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattsse mattsse mattsse approved these changes

@onbjerg onbjerg Awaiting requested review from onbjerg onbjerg is a code owner

@gakonst gakonst Awaiting requested review from gakonst gakonst is a code owner

@DaniPopes DaniPopes Awaiting requested review from DaniPopes DaniPopes is a code owner

@Rjected Rjected Awaiting requested review from Rjected Rjected is a code owner

@fgimenez fgimenez Awaiting requested review from fgimenez fgimenez is a code owner

@emhane emhane Awaiting requested review from emhane emhane is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkysg @emhane @mattsse