feat(exex): canonicalize WAL #11210
Closed
feat(exex): canonicalize WAL #11210
+312
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
A-exex
shekhirin
force-pushed
the
alexey/exex-wal-canonicalize
branch
from
a4bbcfe
to
3bbea71
Compare
shekhirin
force-pushed
the
alexey/exex-wal-canonicalize
branch
from
40a5b05
to
8a1d0e9
Compare
shekhirin
force-pushed
the
alexey/exex-wal-canonicalize
branch
from
8a1d0e9
to
8b49b0b
Compare
mattsse
requested changes
Sep 26, 2024
| /// Canonicalizes the WAL by inserting inverts of notifications that have non-canonical blocks. | ||
| /// | ||
| /// 1. Iterate over all notifications in the WAL in reverse order. | ||
| /// 2. Remove dangling inverted notifications from the previous run of this function. |
There was a problem hiding this comment.
unclear what inverted means here
| /// 4. Invert the notifications using [`ExExNotification::into_inverted`]. | ||
| /// 5. Commit the inverted notifications using [`Wal::commit`]. | ||
| /// | ||
| /// Effectivel, it reverts the WAL to the state of the passed provider, ensuring that the |
There was a problem hiding this comment.
Suggested change
| /// Effectivel, it reverts the WAL to the state of the passed provider, ensuring that the | |
| /// Effectively, it reverts the WAL to the state of the passed provider, ensuring that the |
| @@ -278,6 +282,83 @@ impl ExExManager { | |||
| self.handle.clone() | |||
| } | |||
|
|
|||
| /// Canonicalizes the WAL by inserting inverts of notifications that have non-canonical blocks. | |||
There was a problem hiding this comment.
I think this lacks context about why we're doing this, making all of this very confusing.
Comment on lines
+11
to
+15
| #[derive(Debug, Clone, PartialEq, Eq, Serialize, Deserialize)] | ||
| pub(crate) enum NotificationCommitTarget { | ||
| Commit, | ||
| Canonicalize, | ||
| } |
There was a problem hiding this comment.
dont fully understand why we need to track this?
is this so we know whether we modified this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #11202